Fullscreen types and JSDoc

mirari / vue-fullscreen

A simple Vue.js component for fullscreen

MIT License

439 stars 50 forks source link

Fullscreen types and JSDoc #35

Closed camc314 closed 3 years ago

camc314 commented 3 years ago

Thanks for this Vue Plugin, it works great. I really appreciate you working on getting types in as quickly as possible. This PR is slightly unnecessary, but it fixes 2 minor issues, and adds some JSDoc comments.

To tidy up what ferferga has done I have:

Make target optional (it defaults to document.body)
Added JSDoc info for all functions in the types file (index.d.ts)

mirari commented 3 years ago

2.3.5 released, thank u!