search

miraxes / angular-custom-tour

Custom tour hints
24 stars 12 forks source link

Angular newest version support #17

Closed guilhermejcgois closed 5 years ago

guilhermejcgois commented 5 years ago

This lib supports Angular 5 6 7? I mean, in package.json the dependencies is locked to 4 version...

miraxes commented 5 years ago

Worked for me up to 6 version, didnt try on newest

guilhermejcgois commented 5 years ago

Make sense update versions on package.json file and move to peerDependencies?

miraxes commented 5 years ago

Sure, can you create PR for that? 🥇

guilhermejcgois commented 5 years ago

Yes, I can. How do u want? Make u PR for each major version to publish in npm? (e.g. the first PR moving angular 4 to peerDeps, the second with angular 5, and so on.... )

miraxes commented 5 years ago

@guilhermejcgois You can do it in one, just make sure it still supports older versions. Thanks.