mircea-pavel-anton / pacman

A multiplayer Pacman clone written in C++ using SFML.
GNU General Public License v3.0
15 stars 12 forks source link

about audio file #5

Open 53ndC0r30n1y opened 11 months ago

53ndC0r30n1y commented 11 months ago

I used cmake build the project and it done. but when I run the exe file. they tell me that the backgroundmusic.wav can't open. i don't figure out what reason.

53ndC0r30n1y commented 11 months ago

Good news, I have replaced all the audio files with the same audio file that can be played. The game is running normally, but there is a bug during the gameplay process where the characters will not die and the score can be negative.

mircea-pavel-anton commented 11 months ago

Hi @C3r3brum0n1y thanks for the info. I saw another issue a while ago about building using CMake, however I'm not familiar with it and haven't really worked much in C++ since finishing uni. If you want, you can PR the required files to set up CMake and some short instructions on getting started, and I'll review it and merge it in.

About the audio file, not sure what the issue is, I'll try to look into it this week/weekend.

there is a bug during the gameplay process where the characters will not die and the score can be negative

Can you provide a bit more details? How can I reproduce the issue?

53ndC0r30n1y commented 11 months ago

Hi @mirceanton,thx for your replay.

For the Cmake guide, I may need time to sort out the CmakeLists.txt, make it short, and then send it to you.

About the bugs in the game, maybe I did not completely compile successfully. To be specific, after Pac-Man is touched by a ghost, scores will only be deducted. There is no limit on the number of deaths. This means that the game will not end, even if the score is less than Zero, the game will not end.

53ndC0r30n1y commented 11 months ago

Hi @C3r3brum0n1y thanks for the info. I saw another issue a while ago about building using CMake, however I'm not familiar with it and haven't really worked much in C++ since finishing uni. If you want, you can PR the required files to set up CMake and some short instructions on getting started, and I'll review it and merge it in.

About the audio file, not sure what the issue is, I'll try to look into it this week/weekend.

there is a bug during the gameplay process where the characters will not die and the score can be negative

Can you provide a bit more details? How can I reproduce the issue?

I've replaced the audio files and the files provided in the repository won't open in Windows, I'm assuming that's the reason, so I've found the Pac-Man sound clips on the web and made the replacements.

mircea-pavel-anton commented 11 months ago

after Pac-Man is touched by a ghost, scores will only be deducted. There is no limit on the number of deaths. This means that the game will not end, even if the score is less than Zero, the game will not end.

From a quick look at the code, I don't think that's a bug, it was simply not implemented. I see that upon collision I simply decrease the score without keeping track of positive/negative or lives. The game ends when all pellets are eaten.

https://github.com/mirceanton/pacman/blob/master/src/pacman/GameTile/Movable/Pacman/pacman.cpp#L150C5-L159C9

I've replaced the audio files and the files provided in the repository won't open in Windows

Hmm... I've developed this in Linux so I'll have to check what's the problem with the files on windows.

53ndC0r30n1y commented 11 months ago

ok i got it.