search

mirceanton / external-dns-provider-mikrotik

ExternalDNS webhook to manage Mikrotik DNS Records.
Apache License 2.0
9 stars 1 forks source link

feat: Default Comment #71

Open mircea-pavel-anton opened 2 months ago

mircea-pavel-anton commented 2 months ago

inject a default comment on all records that don't have one specified via MIKROTIK_DEFAULT_COMMENT

mircea-pavel-anton commented 2 months ago

As observed during https://github.com/mirceanton/external-dns-provider-mikrotik/pull/14

Having a default comment injected into the mikrotik DNS record will cause external DNS to detect a mismatch between the current state and the expected state, thus deleting and re-creating the record constantly.

Further investigation would be needed for this, but to be fully honest i am not sure if it is really worth the time and the headache to work around this. I would probably just set up something on the k8s side to have a more robust solution that achieves fundamentally the same thing (a mutating webhook maybe?).

mircea-pavel-anton commented 2 months ago

Leaving this here to see if it gains any traction and people would like such a feature added.

mircea-pavel-anton commented 2 months ago

https://github.com/kubernetes-sigs/external-dns/blob/master/provider%2Faws%2Faws.go#L511-L544

This may be relevant? A similar function comparing expected and current state, keeping track of default values.