Open mircea-pavel-anton opened 1 week ago
Should I validate the connection between the API Client and the actual RouterOS API server as part of the Client creation, Provider creation or neither?
I think it is important to validate the client can connect properly (good credentials, good url etc.) sooner rather than later so that we can fail fast if something is wrong.
After merging some renovate updates that passed the (extremely minimal) testing that was in place, the app has some issues when importing DNS entries from MTK API. As such, better testing is definitely required.
Goals and non-goals
pkg/webhook
as it is simply copy pasted from other providers and I have absolutely 0 clue as to what that code does 😅internal/configuration
andinternal/logging
. I do NOT plan to expand thoseinternal/dnsprovider
TODO
internal/mikrotik/record.go
internal/mikrotik/client.go
where Mikrotik API is mockedinternal/mikrotik/client.go
using https://github.com/EvilFreelancer/docker-routeros ?