search

mirego / accent

The first developer-oriented translation tool. True asynchronous flow between translators and your team.
https://www.accent.reviews
BSD 3-Clause "New" or "Revised" License
1.31k stars 99 forks source link

Add support for msgctxt #118

Closed olafura closed 5 years ago

olafura commented 5 years ago

Second attempt to integrate context. With msgctxt from gettext as the first implementation.

This is in regards to:

113

simonprev commented 5 years ago

This is great, the only thing missing to make the tests pass is to run mix format 👍

olafura commented 5 years ago

@simonprev Done thanks for the guidance ;)

Now I just have to look at why the coverage dropped

simonprev commented 5 years ago

Now I just have to look at why the coverage dropped

You need to add the ContextValues module in the formatter_test.exs file that lists the module to test: https://github.com/mirego/accent/blob/34632e99e4d69cf48d29cc39991da4bc4839e3bd/test/langue/gettext/formatter_test.exs#L8-L16

olafura commented 5 years ago

@simonprev Ah I did that before in the other pr but forgot it in this one ;)

olafura commented 5 years ago

Fixed ;)

olafura commented 5 years ago

@simonprev The Travis CI - Branch check might be broken

simonprev commented 5 years ago

Thank you! 🎉