search

mirego / accent

The first developer-oriented translation tool. True asynchronous flow between translators and your team.
https://www.accent.reviews
BSD 3-Clause "New" or "Revised" License
1.31k stars 99 forks source link

User accounts are in an invalid state [JS artifacts] #164

Closed KevinColemanInc closed 4 years ago

KevinColemanInc commented 4 years ago

I just deployed the project to Heroku via "Deploy with Heroku". Logging in and viewing ownership information shows this JS artifact.

In https://website.com/app/projects/{..}/edit/collaborators in Chrome on OSX:

image

When I try to login in Firefox by hitting the root domain:

image

My ENV config settings in heroku was:

DUMMY_LOGIN_ENABLED: false

KevinColemanInc commented 4 years ago

Might be related to https://github.com/mirego/accent/issues/162

Owner says it is being fixed in next release (11 days ago).

simonprev commented 4 years ago

Yes it is now fixed in master. The main problem is that the Heroku deploy button deploys the master branch and not a stable release 😢 I will look into using "container stack" for the Heroku deploy button.

KevinColemanInc commented 4 years ago

@simonprev

https://devcenter.heroku.com/articles/heroku-button#adding-the-heroku-button

It seems like the button should of been working if the referrer was correctly passed.

In the docs, it seems you can give it a branch name. Maybe you could have a releases branch that only how stable releases?