search

mirego / accent

The first developer-oriented translation tool. True asynchronous flow between translators and your team.
https://www.accent.reviews
BSD 3-Clause "New" or "Revised" License
1.31k stars 99 forks source link

Poor performance on Firefox #203

Closed ad-m closed 3 years ago

ad-m commented 4 years ago

Hello,

I am notice pretty poor performance of Accent UI on Firefox 80.0 (64 bity) on Linux Mint. I don't have experience in UI performance bug reporting. On the same device in Brave Browser (Chromium-based) I don't notice any performance issue. I can not connect performance to specific activity. Just click around and my laptop fan is going fast.

On our instance (running in Docker from official instance) I started recording performance via build-in Firefox Developer Toolbar. Here is screenshot from Firefox to show issue:

obraz

We can see that FPS is going down sometime.

Here is call stack:

obraz

It looks like the performance issues are concentrated around one place and it exists on Javascript-side.

Here is recorded profile data: https://files.jawne.info.pl/private_html/2020_09_shaeDuokiateeShut4AiJohThahk0ieR8eiweecuquoteeNgux In can be open in Firefox or at http://perfht.ml/ for futher analysis.

I have impression that there is some callback-loop: obraz

obraz

Everything is in single file.

obraz

I probably need to run without minitifaction the code to successfully get to the problem, but currently I'm not sitting down to that, so I'm leaving at least a trace.

Kind regards, Adam Dobrawy

filipcro commented 3 years ago

Same thing happened on my MacBook. I got around 2.65 FPS in Firefox. I used provided demo application.

It works much better in Edge, but still slower than it should be. Those dropdowns are lagging a lot.

image

Those are my specs: image

simonprev commented 3 years ago

The power select component was the culprit. The simple selects are now native and will not consume so much memory

ad-m commented 3 years ago

How to verify which release have that fix? I would like upgrade Accent and verify there are no other problems here for my setup to support development of Accent.

simonprev commented 3 years ago

I think the select was refactored in 1.6.0 but you can upgrade to latest (now 1.8.3) since it does not break anything and you will have all the other fixes and features