Cleanup Unicode context for iOS .strings

mirego / accent

The first developer-oriented translation tool. True asynchronous flow between translators and your team.

https://www.accent.reviews

BSD 3-Clause "New" or "Revised" License

1.3k stars 97 forks source link

Cleanup Unicode context for iOS .strings #341

Closed v-dev-207 closed 1 year ago

v-dev-207 commented 1 year ago

Issue: https://github.com/mirego/accent/issues/340

it's related to the file encoding!

the attached file contained non-unicode or un-printable letters. so failed while reading <> parsing the file. so i added the utility module to convert binary to string by removing those wrong bytes.

v-dev-207 commented 1 year ago

Hi @simonprev
I think i've resolved the issue #340 in this PR. Could you please have time to review this one?

simonprev commented 1 year ago

Hey @v-dev-207 thanks for the report, I ended up fixing it and adding test in the same commit: https://github.com/mirego/accent/commit/c0cb687fe69d22dee64ce7f11f25b87c154d741c

Open a new issue if something is still off 😃

v-dev-207 commented 1 year ago

Hi @simonprev Great, thanks.