mirego / credo_naming

🏷 A suite of Credo checks to enforce naming best practices in an Elixir project
https://open.mirego.com
BSD 3-Clause "New" or "Revised" License
88 stars 9 forks source link

Support umbrella apps #1

Closed liskin closed 5 years ago

liskin commented 5 years ago

Fix root path detection for umbrella apps, plus two small cleanups.

remi commented 5 years ago

This is awesome! 🎉

If you have time to add both Elixir versions (1.7 and 1.8) to .travis.yml so they are both officially tested, I’ll merge it right after.

If you don’t have time, no worries, I’ll merge it right now and edit .travis.yml afterwards.

Thank you!

remi commented 5 years ago

This is great, thank you Tomáš! I’ll cut the 0.2.0 right after this.

liskin commented 5 years ago

Thanks for merging.

BTW, I'm new to Elixir and its community and I've been wondering if merging via squashing is the standard here because this is my second Elixir-related PR that was merged in that way and it's making me somewhat uncomfortable as there's now a squashed commit authored by me in some git history somewhere and I always strived to make proper commits that don't mix unrelated changes... But if this is standard in the Elixir community, I can live with that, I guess. :-)

remi commented 5 years ago

BTW, I'm new to Elixir and its community and I've been wondering if merging via squashing is the standard here because this is my second Elixir-related PR that was merged in that way

I think it’s just a coincidence :)

It's making me somewhat uncomfortable as there's now a squashed commit authored by me in some git history somewhere and I always strived to make proper commits that don't mix unrelated changes...

This is just my personal preference as an open-source project maintainer. I always try to keep a clean git history in the master branch. For instance when you look at the history for this repo, you see a Support umbrella apps commit, not all the individual commits that amounted to the whole feature (eg. refactors from PR comments, minor stuff like formatting, etc.).

Thank you for contributing!

liskin commented 5 years ago

Okay, thanks for clarifying. :-)