mirego / credo_naming

🏷 A suite of Credo checks to enforce naming best practices in an Elixir project
https://open.mirego.com
BSD 3-Clause "New" or "Revised" License
89 stars 9 forks source link

Warnings following Credo 1.4.0 update #10

Closed gcauchon closed 4 years ago

gcauchon commented 4 years ago

Credo 1.4.0 introduced a new validation of check params in config which prints the following warnings when using CredoNaming checks:

> mix credo --strict
** (config) CredoNaming.Check.Warning.AvoidSpecificTermsInModuleNames: unknown param `terms`.
** (config) CredoNaming.Check.Consistency.ModuleFilename: unknown param `excluded_paths`.
Checking 92 source files (this might take a while) ...
…

I think we need to change the way we are "using" Credo.Check to provide the missing options:

https://hexdocs.pm/credo/Credo.Check.html

remi commented 4 years ago

Yep, that makes sense. Do you want to tackle this?

gcauchon commented 4 years ago

Do you want to tackle this?

As soon as I have a few minutes to spare…

sitch commented 4 years ago

bump!