mirego / credo_naming

🏷 A suite of Credo checks to enforce naming best practices in an Elixir project
https://open.mirego.com
BSD 3-Clause "New" or "Revised" License
89 stars 9 forks source link

Deprecate `:phoenix` atom as predefined plugin #29

Closed remi closed 1 year ago

remi commented 1 year ago

đź“– Description and reason

Following @paveltyk’s suggestion in #28, let’s favor the use of CredoNaming.Check.Consistency.ModuleFilename.Plugins.Phoenix as our predefined plugin instead of the opaque :phoenix atom.

:phoenix is still supported for backward-compatibility.

🦀 Dispatch

#dispatch/elixir

paveltyk commented 1 year ago

@remi why do you want to limit plugins to only predefined plugins with when plugin in @plugins ? How do you feel about allowing any module that provides Behavior to be used? That will allow for greater flexibility.

Thank you for a great credo check :)

paveltyk commented 1 year ago

Will you please bump a version for new changes?

remi commented 1 year ago

@remi why do you want to limit plugins to only predefined plugins with when plugin in @plugins ? How do you feel about allowing any module that provides Behavior to be used? That will allow for greater flexibility.

Oh wait, that’s not what I wanted to do at all 🤦‍♂️ That doesn’t make sense. Let me fix this.

paveltyk commented 1 year ago

đź‘Ť

remi commented 1 year ago

@paveltyk 2.1.0 was just released!

https://hex.pm/packages/credo_naming/2.1.0