Open nicklayb opened 5 years ago
I think your plan covers the webhook and fetching repository metadata, which is 2/3 of the cycle. Have you look at the code that actually assign reviewers and post the comment in the PR stream?
I may have mistakenly skipped that part, I was sure it was part of the GitHubClient module actually.
Can you point me out this part of the code?
@nicklayb correct me if i'm wrong, which i think you'll haha but it would only need a bitbucket_client
matching what the client_behavior
need .
As we talked, I would like to implement Bitbucket support in Dispatch and pave the ground for other support such as GitLab. I browsed the code a bit and here is how I'm planning to implement it:
provider
where you can set eithergithub
orbitbucket
(defaults to github for backward compatibility):create
action in Webhooks.Controller for:github
which will call the Webhooks.GitHub module (and point the route to :github):bitbucket
action in Webhooks.Controller which uses the Webhooks.Bitbucket module with a route/webhooks/bitbucket
provider
config variable.Anything I forgot? Any recommandation?