mirego / dispatch

🦀 Dispatch makes sure pull requests within a GitHub organization get reviewed by the right people.
https://open.mirego.com
BSD 3-Clause "New" or "Revised" License
25 stars 3 forks source link

Support for Bitbucket hooks #10

Open nicklayb opened 5 years ago

nicklayb commented 5 years ago

As we talked, I would like to implement Bitbucket support in Dispatch and pave the ground for other support such as GitLab. I browsed the code a bit and here is how I'm planning to implement it:

Anything I forgot? Any recommandation?

gcauchon commented 5 years ago

I think your plan covers the webhook and fetching repository metadata, which is 2/3 of the cycle. Have you look at the code that actually assign reviewers and post the comment in the PR stream?

nicklayb commented 5 years ago

I may have mistakenly skipped that part, I was sure it was part of the GitHubClient module actually.

Can you point me out this part of the code?

GabDesilets commented 5 years ago

@nicklayb correct me if i'm wrong, which i think you'll haha but it would only need a bitbucket_client matching what the client_behavior need .