Allow stacks with a dot in their name

mirego / dispatch

🦀 Dispatch makes sure pull requests within a GitHub organization get reviewed by the right people.

https://open.mirego.com

BSD 3-Clause "New" or "Revised" License

25 stars 3 forks source link

Allow stacks with a dot in their name #22

Closed Madumo closed 4 years ago

Madumo commented 4 years ago

When we declare the related stacks of a PR within it's description, the regex to extract those stacks didn't allow for a dot in it's name.

When requesting reviewers for the stack #dispatch/node.js, the extracted stack name was node, not node.js. Since node didn't match any stacks within our config, it was ignored.

This change to the regex will a correctly capture node.js instead of just node.

mirego-builds commented 4 years ago

🦀 Requesting reviewers for this pull request:

@garno (contributor with 0 commits in the last 90 days and 5 commits overall)

garno commented 4 years ago

Can you add a small test to ensure we do not break this behaviour in the future?

Madumo commented 4 years ago

@garno Ha! I pushed a test 15 seconds before you submitted your comment 😎