Translation layer for veekun and Showdown in pokedexreader

[mirekdlugosz]

veekun Pokedex and Pokemon Showdown! are using different ids for Pokemon and moves. We need to align them in order to be able to create single pokedex from multiple sources in pokedexreader.

My idea is:

• use moves ids from Showdown main difference is that veekun uses dash in place of space, while Showdown removes spaces and dashes. It's easy to translate veekun to Showdown, but very hard the other way around (would require a lot of heuristics and extensive list of hard-coded translations)
• use pokemon ids from veekun most pokemon ids are the same in both games. List of differences is relatively small and would be easy to contain in constants file. Using veekun ensures backwards compatibility. On the other hand, it might create chaos down the road, if veekun is updated and our Showdown-ids don't match. We would then need to add veekun -> Showdown translations, but only for game FooBar and later. So might as well switch to Showdown now and deal with backwards compatibility only once.

Providing Showdown -> veekun translation might be as easy as creating veekun -> Showdown map and swapping key with value:

veekun_to_showdown = {item: item.replace('-', '') for item in veekun_moves}
showdown_to_veekun = {val: key for key, val in veekun_to_showdown.items()}
two_way_map = {**veekun_to_showdown, **showdown_to_veekun}

However, this will couple Showdown reader with veekun reader - veekun will be allowed as standalone data source, while Showdown will be always only auxiliary data source.

[mirekdlugosz]

This is being worked on in branch showdown-27.

[mirekdlugosz]

I decided to switch to Showdown ids exclusively:

• translation from veekun ids is easy - all moves can be translated by simply removing dash from id, most of Pokemon can be translated in the same way (exceptions list is small enough to keep it hardcoded in some constant)
• there is high chance that we won't be using veekun data for future generations at all
• it will remove one of stumbling block on road towards #9

Until Showdown reader is completed (#28 and #29), there is not much to be done here. It's actually veekun reader that must be changed.

[mirekdlugosz]

Done in 213ec8611d7fcb1f7825c225bad7cf2dab7fc3ad..4df5a217f2ef17b97b772b81568186841273b935