mirekdlugosz / create-pokemon-team

Web application that helps you build your own Pokémon team in any core series game
https://createpokemon.team/
GNU Affero General Public License v3.0
12 stars 3 forks source link

Add edge-cases support in Pokemon Showdown pokedex reader #29

Closed mirekdlugosz closed 4 years ago

mirekdlugosz commented 5 years ago

Once #26 is done, extend Pokemon Showdown pokedex reader class to support edge cases:

mirekdlugosz commented 4 years ago

Peculiar edge case: there are Pokemon with multiple forms, where each form has different moveset, but Pokemon can change form at the whim. Moves from one form are available to another form. But there is a catch - some forms are not available in all games in generation.

mirekdlugosz commented 4 years ago

Mostly done in branch showdown-full, which was rebased and merged into master as commits 0c44227c8c692e0c424171a11341962579650384..7d16e75aca98f0f18e96c97130a2544a62975316. Remaining issues require changes to pokedex class and constants, and they will break veekun reader - so they will need to be done as part of #27 and/or #30. Also, exceptions from previous comment are not handled properly. This has now new issue #38.