search

mirfatif / MyLocation

Know your geo coordinates using on-device GPS and Network location providers
GNU Affero General Public License v3.0
63 stars 6 forks source link

Include Nominatim (UnifiedNlp) #13

Open IzzySoft opened 1 year ago

IzzySoft commented 1 year ago

Would it be possible to also include the UnifiedNlp Nominatim backend if installed, so one could see if it properly resolves?

gdt commented 1 year ago

I think that makes sense, and presumably it would look up the GNSS location, or the network location, or maybe both. It's new scope as currently only location provider backends are queried and the API has to be different, but I think it fits within the scope of the app.

IzzySoft commented 1 year ago

Yupp. It would use the coordinates obtained from any of the location providers (the one with the best precision) and pass that to the Nominatim backend, then check (and show) the result.

mirfatif commented 1 year ago

https://github.com/microg/UnifiedNlp/blob/master/api/src/main/aidl/org/microg/nlp/api/GeocoderBackend.aidl

IzzySoft commented 1 year ago

??? Looks like the text part of your comment was lost. Not being an Android dev I'm not sure what the code you've linked to is supposed to tell me, @mirfatif :wink:

…apart from the fact that this is a commit from 2019, while the last release of the NominatimBackend was 2017. So is there a fixed version? I've reason to assume that the last release available at F-Droid (1.2.2) no longer works, at least not on Android 9+.

mirfatif commented 1 year ago

For you is the "enhancement" label. Comment is for me or someone who is interested in implementing this feature in future.