search

mirleft / ocaml-asn1-combinators

Embed typed ASN.1 grammars in OCaml
ISC License
35 stars 20 forks source link

[wip] port to Dune #22

Closed avsm closed 5 years ago

avsm commented 5 years ago

This is a work in progress port to shift to the Dune build system, which in turn permits the library to embedded as a single dune build as part of a monorepo. More information on this vendoring mechanism is available here.

I'm still working on the port, but opening this PR to track it.

TheLortex commented 5 years ago

@avsm what is missing to merge this ?

hannesm commented 5 years ago

AFAICT, the src/dune does not "wrap" (this is good!), but it will expose all the modules in src, rather than only Asn (as done in the ocamlbuild build). To avoid this, all but asn should be part of a private_modules stanza.

avsm commented 5 years ago

Thanks for the review @hannesm -- I've pushed those fixes now

pqwy commented 5 years ago

Thx, dune'd.