search

mirleft / ocaml-nocrypto

OCaml cryptographic library
ISC License
111 stars 53 forks source link

nuke sexplib/ppx #118

Closed vbmithr closed 7 years ago

vbmithr commented 7 years ago

Because using ppx is not a good idea, actually.

I'll take my nocrypto without ppx, thank you very much :)

haesbaert commented 7 years ago

Why ? Can you elaborate ?

I actually use and like it.

vbmithr commented 7 years ago

With latest version of janestreet software (dev), it makes it hard to compile, and in general, ppx is very dependent of OCaml version being used, at least it was the case until recently. I suppressed it because I could not compile nocrypto anymore when using janestreet dev libraries.

haesbaert commented 7 years ago

That looks like the wrong fix then.

Can't we fix janestreet dev libraries ? I use sexp on other projects as well, I'd to have to write 582 new functions for my dhcp library cause we can't use sexp anymore.

On Wed 5. Apr 2017 at 11:32, Vincent Bernardoff notifications@github.com wrote:

With latest version of janestreet software (dev), it makes it hard to compile, and in general, ppx is very dependent of OCaml version being used, at least it was the case until recently. I suppressed it because I could not compile nocrypto anymore when using janestreet dev libraries.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mirleft/ocaml-nocrypto/pull/118#issuecomment-291806821, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMdELvJfAOSTTgKIXmR2Od0_I0pMUMOks5rs1-zgaJpZM4Mrg37 .

haesbaert commented 7 years ago

I found the original sexp discussion thread now.

That is depressing. Really depressing.

On Wed 5. Apr 2017 at 12:26, Christiano F. Haesbaert < haesbaert@haesbaert.org> wrote:

That looks like the wrong fix then.

Can't we fix janestreet dev libraries ? I use sexp on other projects as well, I'd to have to write 582 new functions for my dhcp library cause we can't use sexp anymore.

On Wed 5. Apr 2017 at 11:32, Vincent Bernardoff notifications@github.com wrote:

With latest version of janestreet software (dev), it makes it hard to compile, and in general, ppx is very dependent of OCaml version being used, at least it was the case until recently. I suppressed it because I could not compile nocrypto anymore when using janestreet dev libraries.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mirleft/ocaml-nocrypto/pull/118#issuecomment-291806821, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMdELvJfAOSTTgKIXmR2Od0_I0pMUMOks5rs1-zgaJpZM4Mrg37 .

cfcs commented 7 years ago

What is janestreet software (dev)? Have they fixed ppx yet?

rgrinberg commented 7 years ago

Is this still a problem? I think janestreet fixed this.

haesbaert commented 7 years ago

It's all fixed.

pqwy commented 7 years ago

I don't particularly like dragging that stuff in either, but it's been used pretty widely. Some uniform external representation is pretty handy, and you probably don't want me to replace sexps with the equivalent ASN.1 😈 .

A birdie told me @dbuenzli has a sexplib-like thing in the pipeline. That's an option.