mirleft / ocaml-nocrypto

OCaml cryptographic library
ISC License
111 stars 53 forks source link

opam install fails on 4.06 with patch file errors #149

Open RazorSh4rk opened 6 years ago

RazorSh4rk commented 6 years ago
The following actions will be performed:
  ∗  install nocrypto 0.5.4-1

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[default] https://opam.ocaml.org/archives/nocrypto.0.5.4-1+opam.tar.gz downloaded

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[ERROR] Patch file "/home/razor/.opam/4.06.1/build/nocrypto.0.5.4-1/0002-add-missing-runtime-dependencies-in-_tags.patch" not found.
[ERROR] Patch file "/home/razor/.opam/4.06.1/build/nocrypto.0.5.4-1/0004-add-ppx_sexp_conv-as-a-runtime-dependency-in-the-pac.patch" not found.
[ERROR] Patch file "/home/razor/.opam/4.06.1/build/nocrypto.0.5.4-1/0005-Auto-detect-ppx_sexp_conv-runtime-library.patch" not found.
[ERROR] Patch file "/home/razor/.opam/4.06.1/build/nocrypto.0.5.4-1/0006-pack-package-workaround-ocamlbuild-272.patch" not found.

#=== ERROR while installing nocrypto.0.5.4-1 ==================================#
These patches didn't apply at /home/razor/.opam/4.06.1/build/nocrypto.0.5.4-1:
  - 0006-pack-package-workaround-ocamlbuild-272.patch
  - 0005-Auto-detect-ppx_sexp_conv-runtime-library.patch
  - 0004-add-ppx_sexp_conv-as-a-runtime-dependency-in-the-pac.patch
  - 0002-add-missing-runtime-dependencies-in-_tags.patch

=-=- Error report -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
The following actions failed
  ∗  install nocrypto 0.5.4-1
No changes have been performed

When i ls the nocrypto folder, the patch files are

ls ~/.opam/4.06.1/build/nocrypto.0.5.4-1/
0001-add-missing-runtime-dependencies-in-_tags.patch             bench       lwt              pkg        _tags
0002-add-ppx_sexp_conv-as-a-runtime-dependency-in-the-pac.patch  CHANGES.md  mirage           README.md  tests
0003-Auto-detect-ppx_sexp_conv-runtime-library.patch             doc         myocamlbuild.ml  rfc        unix
0004-pack-package-workaround-ocamlbuild-272.patch                LICENSE.md  opam             src

Installed without issue on 4.02, am I missing something?

hannesm commented 6 years ago

which operating system are you on? which opam version do you use? did you run opam update? your opam output refers to 0002/4/5/6*.patch, while your ls output lists 0001/2/3/4*.patch!?

RazorSh4rk commented 6 years ago

I'm on linux mint 18.3, with opam version 1.2.2. I ran update before.

hannesm commented 6 years ago

@RazorSh4rk that is strange, which files are listed in your ~/.opam/repo/default/packages/nocrypto/nocrypto.0.5.4-1/opam? 0001-0004 or 0002,0004,0005,0006? Your downloaded nocrypto.0.5.4-1+opam.tar.gz (should be in ~/.opam/archives) is the same one as this? for me its sha256 is 87675352259e20fdb3065a8e0e28eaebbe038313386715bd5a4494e7f16308d6!

RazorSh4rk commented 6 years ago
opam-version: "1.2"
homepage:     "https://github.com/mirleft/ocaml-nocrypto"
dev-repo:     "https://github.com/mirleft/ocaml-nocrypto.git"
bug-reports:  "https://github.com/mirleft/ocaml-nocrypto/issues"
doc:          "https://mirleft.github.io/ocaml-nocrypto/doc"
authors:      ["David Kaloper <david@numm.org>"]
maintainer:   "David Kaloper <david@numm.org>"
license:      "ISC"
tags:          [ "org:mirage" ]
available:     [ ocaml-version >= "4.02.0" & os != "freebsd" & os != "openbsd" ]

build: ["ocaml" "pkg/pkg.ml" "build" "--pinned" "%{pinned}%" "--tests" "false"
                "--jobs" "1"
                "--with-lwt" "%{lwt:installed}%"
                "--xen" "%{mirage-xen:installed}%"
                "--freestanding" "%{mirage-solo5:installed}%"]

depends: [
  "ocamlfind" {build}
  "ocamlbuild" {build}
  "topkg" {build}
  "cpuid" {build}
  "ocb-stubblr" {build}
  "ppx_deriving"
  "ppx_sexp_conv" {>= "113.33.01" & != "v0.11.0"}
  "ounit" {test}
  "cstruct" {>="2.4.0"}
  "cstruct-lwt"
  "zarith"
  "lwt"
  "sexplib"
  ("mirage-no-xen" | ("mirage-xen" & "mirage-entropy" & "zarith-xen"))
  ("mirage-no-solo5" | ("mirage-solo5" & "mirage-entropy" & "zarith-freestanding"))
]

conflicts: [
  "topkg" {<"0.9.1"}
  "ocb-stubblr" {<"0.1.0"}
  "mirage-xen" {<"2.2.0"}
  "sexplib" {="v0.9.0"}
]

patches: [
    "0001-add-missing-runtime-dependencies-in-_tags.patch"
    "0002-add-ppx_sexp_conv-as-a-runtime-dependency-in-the-pac.patch"
    "0003-Auto-detect-ppx_sexp_conv-runtime-library.patch"
    "0004-pack-package-workaround-ocamlbuild-272.patch"
]

Yes, the tar.gz has the same patch files as the /build folder.

I got around this by opam install nocrypto.0.5.4 if anyone has the same problem, but it's still strange.