search

mirleft / ocaml-nocrypto

OCaml cryptographic library
ISC License
111 stars 53 forks source link

Support cstruct +3.4.0 #157

Closed psafont closed 4 years ago

psafont commented 5 years ago

Build using cstruct-lwt instead of cstruct.lwt, as per instructions on https://discuss.ocaml.org/t/psa-cstruct-3-4-0-removes-old-ocamlfind-subpackage-aliases/3275

Fixes https://github.com/mirleft/ocaml-nocrypto/issues/155

psafont commented 5 years ago

Not sure what's causing the bubblewrap installation failure in the failing travis job, could be a transient failure but I can't re-trigger it:

+sudo apt-get install -y bubblewrap
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Unable to locate package bubblewrap
The command "bash -ex .travis-opam.sh" exited with 100.
copy commented 5 years ago

@avsm has already submitted patches for this package to opam-repository that fix support with cstruct 3.4 and 4.0: https://github.com/ocaml/opam-repository/pull/13655 https://github.com/ocaml/opam-repository/pull/13755

avsm commented 5 years ago

Ah yes thanks -- I haven't been looking at the master branch with my patches so forward-porting them would be appreciated

psafont commented 5 years ago

I've added an explicit dependency on sexplib on the opam file too, otherwise it wouldn't work.

psafont commented 5 years ago

@pqwy is there anything stopping this PR from being merged?

XVilka commented 5 years ago

@avsm @hannesm shouldn't this be merged then? Also, does it support cstruct-5.0.0?

XVilka commented 5 years ago

Ping?

psafont commented 4 years ago

Closing as I've replaced nocrypto with mirage-crypto on the projects I'm involved with.