use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct)

mirleft / ocaml-x509

X509 (RFC5280) handling in OCaml

BSD 2-Clause "Simplified" License

52 stars 33 forks source link

use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) #115

Closed hannesm closed 5 years ago

hannesm commented 5 years ago

while re-reading the PR and RFC 5280 again, I discovered that the CRLissuer in the distributionPoint extension is a GeneralName (not a DistinguishedName) - fixed in a commit above, and also printing of DistinguishedName.t now uses / as separator, as commonly used by other tools. i plan to merge and release this later today unless there's any substantiated objection (or travis complains).