search

mirnovov / obsidian-homepage

An Obsidian plugin that opens a specified note, canvas, or workspace on startup, instead of the most recent one.
MIT License
397 stars 19 forks source link

[BUG] Tabs are not rendered in Obsidian 1.2.2 #44

Closed OmniNaut closed 1 year ago

OmniNaut commented 1 year ago

Summary

Since the update to Obsidian 1.2.X the plugin does not render tabs anymore

Steps to reproduce

Plugin enabled: image

Should be: image

Obsidian info

image

Happens with default theme and minimal theme

Obsidian version

1.2.2 Windows

Checklist

mirnovov commented 1 year ago

Unfortunately I'm not part of the insider program, so I can't debug this. I'll keep this issue open and wait until 1.2.x is released to the public. I've purchased an Catalyst license and have developed a fix that works on 1.2.x.

OmniNaut commented 1 year ago

~ I've purchased an Catalyst license and have developed a fix that works on 1.2.x.

Awesome, welcome to the catalyst club 👍🏼

OmniNaut commented 1 year ago

It is still broken for me with version 3.0 of the plugin. Obsidian upgraded also to 1.2.3 automatically, so I don't know if the issue was fixed for 1.2.2 and regressed back into 1.2.3.

mirnovov commented 1 year ago

Sorry about that.

Unfortunately, I can't seem to reproduce this on 1.2.3. Have you got any conflicting plugins that might be causing any issues? 3.0 has a new "copy debug info" button at the bottom of the homepage settings pane that lists them all, so you can just copy that.

OmniNaut commented 1 year ago

Sorry about that.

Unfortunately, I can't seem to reproduce this on 1.2.3. Have you got any conflicting plugins that might be causing any issues? 3.0 has a new "copy debug info" button at the bottom of the homepage settings pane that lists them all, so you can just copy that.

On your suggesting I disabled and individually enabled community plugins again. I found the culprit. It's the plugin Obsidian New Tab. It's just a simple plugin without any further options to experiment with.

If I disable Homepage and enable New Tab the expected behaviour is fine. It's only the combination of the two plugins that makes this behaviour appear. I cannot tell which of the two plugins is the real culprit in this.

Unfortunately I can't find the "copy debug info" button you're talking about. Can you point me in the right direction?

Thank you for looking into this

mirnovov commented 1 year ago

If I disable Homepage and enable New Tab the expected behaviour is fine. It's only the combination of the two plugins that makes this behaviour appear. I cannot tell which of the two plugins is the real culprit in this.

Thanks for the pointer - I'll sort something out and/or include a fix for it in an upcoming release. I already have special case code for other plugins which interact with tabs, so it's not a huge deal.

Unfortunately I can't find the "copy debug info" button you're talking about. Can you point me in the right direction?

It's at the bottom right of the homepage settings:

Untitled

I know it's not the most obvious but given that most users won't use it I didn't want it to get in the way.

OmniNaut commented 1 year ago

image

I have completely different settings page

OmniNaut commented 1 year ago

Ok, I have reinstalled the plugin and now I have the correct settings page. I copied the debug info

{"version":3,"homepages":{"Main Homepage":{"value":"Dashboard.canvas","kind":"File","openOnStartup":true,"hasRibbonIcon":true,"openMode":"Replace all open notes","manualOpenMode":"Keep open notes","view":"Default view","revertView":true,"refreshDataview":false,"autoCreate":true,"autoScroll":false,"pin":false,"commands":[]}},"separateMobile":false,"_plugins":["obsidian-audio-notes","obsidian-auto-hide","awesome-reader","buttons","obsidian-chartsview-plugin","dataview","creases","dbfolder","double-colon-conceal","obsidian-excalidraw-plugin","obsidian-full-calendar","heading-level-indent","local-quotes","make-md","metadata-menu","periodic-notes","obsidian-minimal-settings","pinterest-widget-obsidian","obsidian-projects","quickadd","obsidian-style-settings","templater-obsidian","obsidian-toggle-meta-yaml-plugin","obsidian-tracker","open-in-new-tab","homepage"],"_internalPlugins":["file-explorer","global-search","switcher","graph","canvas","outgoing-link","tag-pane","page-preview","note-composer","command-palette","editor-status","bookmarks","outline","file-recovery"],"_obsidianVersion":"1.2.3"}

mirnovov commented 1 year ago

Seems like the settings page broke for some reason, I'll look into that. Anyway, it's definitely open-in-new-tab causing your problems, I can reproduce it now.

mirnovov commented 1 year ago

Unfortunately, I can't really create a fix on my end, so I've submitted a PR to the developer of the open-in-new-tab plugin. Hopefully they implement it, though ofc it's ultimately up to them.

BTW, the issue that lead to your settings not working earlier should be fixed in fdaa42d592aec0a7912822d3426139b23bc8f865. Thanks for the help finding the root of this problem @OmniNaut, it's very much appreciated.

OmniNaut commented 1 year ago

Thanks for your effort as well 👍🏼

peterzhu1992 commented 1 year ago

Since there is no attraction in https://github.com/patleeman/obsidian-open-in-new-tab/pull/9, I just go ahead and include @mirnovov fix in my own fork, and release on BRAT so if anyone has this conflict they can use it. https://github.com/peterzhu1992/obsidian-open-in-new-tab-homepage-fix/releases/tag/1.0.9h

Thanks.