miro-ka / mosquito

Trading Bot with focus on Evolutionary Algorithms and Machine Learning
GNU General Public License v3.0
260 stars 53 forks source link

Bittrex API deprecated call #43

Closed AdityaNayak closed 6 years ago

AdityaNayak commented 6 years ago

Hi, I get this error while running with the latest version of bittrex wrapper

 res = self.bittrex.get_ticks(currency_pair, 'fiveMin')
AttributeError: 'Bittrex' object has no attribute 'get_ticks'
miro-ka commented 6 years ago

Please can you check if you use following bittrex api https://github.com/miti0/python-bittrex? I have extended the original bittrex library with get_ticks function.

AdityaNayak commented 6 years ago

That removed the get_ticks error. It started generating this though:

Starting simulation: TradeMode.backtest, Strategy: bumblebee
Getting currency data: BTC_DOGE, days left: 1 (got total candles: 288)
Going to prefetch data of size (minutes):  300
Fetching done..
dataset_cnt: 60
Traceback (most recent call last):
  File "mosquito.py", line 35, in <module>
    main(args)
  File "mosquito.py", line 9, in main
    engine.run()
  File "/Users/AdityaNayak/Bots/mosquito/core/engine.py", line 179, in run
    self.actions = self.strategy.calculate(self.look_back, self.wallet)
  File "/Users/AdityaNayak/Bots/mosquito/strategies/bumblebee.py", line 69, in calculate
    obv = talib.OBV(close, volume)
  File "talib/func.pyx", line 9213, in talib.func.OBV (talib/func.c:97907)
Exception: inputs are all NaN
miro-ka commented 6 years ago

Thank you for reporting this :). Please can you double check if you have following (Bittrex is using '-' and Poloniex '_')?

Btw: I have just now fixed one bug, so please pull the latest develop branch.

AdityaNayak commented 6 years ago

Yes, same issue.

I have pulled your latest develop branch. And changed the pairs on all 3 places.

Also, backtesting should work without adding API keys, correct?

miro-ka commented 6 years ago

yes it should.

Can you come to gitter,..can help you faster there,...

miro-ka commented 6 years ago

Please, did you do any modifications to the strategy or config.ini? If yes, can you please paste it here?

miro-ka commented 6 years ago

I believe this was fixed,..closing