search

miroRucka / bh1750

MIT License
3 stars 5 forks source link

Support Node 10 #22

Closed rzr closed 4 years ago

rzr commented 5 years ago

It looks like i2c module is no more maintained maybe we can use an other i2c implementation ?

Relate-to: https://github.com/kelly/node-i2c/issues/90 Relate-to: https://github.com/kelly/node-i2c/issues/91

shidevil commented 4 years ago

@rzr Will it support node 12? with abandonware i2c.

rzr commented 4 years ago

I think so, I would make sense to merge it , then I will rebase and check

meanwhile use the abandonware version:

https://github.com/abandonware/bh1750

May I also suggest to try: https://github.com/rzr/generic-sensors-lite

shidevil commented 4 years ago

Sadly i tried abandonware i2c and it doesn't compile with node 12. i2c failed to compile.

rzr commented 4 years ago

Then please file bug in https://github.com/kelly/node-i2c/issues or share patches to: https://github.com/abandonware/node-i2c

shidevil commented 4 years ago

@rzr Will file a bug there. Thanks

rzr commented 4 years ago

Relate-to: https://github.com/kelly/node-i2c/issues/98

rzr commented 4 years ago

I think this issue can be solved master branch has my changes in

Meanwhile it is released you can use:

https://www.npmjs.com/package/@abandonware/bh1750/v/0.0.7-2