search

miroapp / tap-appstore

A Singer.io tap for Apple App Store sales report
GNU Affero General Public License v3.0
5 stars 18 forks source link

Implement probing discovery #3

Closed sherifnada closed 3 years ago

sherifnada commented 3 years ago

This tap currently syncs 4 reports. Three are subscription related, and one is sales related. If an app on the appstore does not support subscriptions or sales, it cannot pull the relevant reports. However, the way the Appstore API expresses this is not via clear error messages. Instead it expresses it by throwing an unrelated error, in this case "invalid vendor ID". This problem was encountered in https://github.com/airbytehq/airbyte/issues/2162

This PR fixes the issue by having discover return the catalog containing only the report streams which the account can download.

sherifnada commented 3 years ago

@JustEdro @Muriloo can you take a look?