search

miroiu / nodify

Highly performant and modular controls for node-based editors designed for data-binding and MVVM.
https://miroiu.github.io/nodify
MIT License
1.3k stars 208 forks source link

[Bug] Connections can be created cross graphs #37

Closed miroiu closed 1 year ago

miroiu commented 2 years ago

Describe the bug It is possible to connect nodes to child graphs, which is not intended and will result in bad Anchor calculations.

To Reproduce Add an operation graph in the calculator example and connect a node from the root graph to another node inside the operation graph.

Expected behavior I should not be able to create connections across graphs.

Screenshots In this example, the output of the Add node is connected to the input of the Output parameters nodes inside the Operations graph.

image

AnvarAslam commented 1 year ago

Can I Solve These Issue

miroiu commented 1 year ago

Hi @AnvarAslam! You can solve it! Please let me know if you need more information.

AnvarAslam commented 1 year ago

i am little bit confuse can u help to get started

miroiu commented 1 year ago

You can start by looking at what the PendingConnection does.

miroiu commented 1 year ago

Hi! I fixed this issue for the v4.0.0 release.