search

miroiu / nodify

Highly performant and modular controls for node-based editors designed for data-binding and MVVM.
https://miroiu.github.io/nodify
MIT License
1.36k stars 221 forks source link

Settings panel from viewmodel #62

Closed Riju-bak closed 1 year ago

Riju-bak commented 1 year ago

📝 Description of the Change

What is this pull request about?

This PR is a fix for issue https://github.com/miroiu/nodify/issues/22

Nodify.Playground's playground settings can now be initialized in a List from within PlaygroundSetting.cs and the changes will be reflected in PlaygroundSettingsView.xaml.

Similarly Nodify.Playground's editor settings can be initialized in a List inside EditorSetting.cs and the changes will be reflected in EditorSettingsView.xaml.

This will make it easier to add new settings and/or change the order of the settings.

🐛 Possible Drawbacks

Are there any possible side-effects or negative impacts with this code change?

Riju-bak commented 1 year ago

Whenever at a future point it is okay to merge, can you let me know before you do that? I think it's better to squash all the commits for this feature before final merging.

miroiu commented 1 year ago

Whenever at a future point it is okay to merge, can you let me know before you do that? I think it's better to squash all the commits for this feature before final merging.

There's one final item that needs to be fixed and I can merge it. You don't need to squash commits because there's an option to Squash and merge.

miroiu commented 1 year ago

Thank you very much for your contribution!

Riju-bak commented 1 year ago

Thank you very much for your contribution!

You're very welcome :) .