search

miromannino / Justified-Gallery

Javascript library to help creating high quality justified galleries of images. Used by thousands of websites as well as the photography community 500px.
http://miromannino.github.io/Justified-Gallery/
MIT License
1.68k stars 299 forks source link

Margin incorrect at narrow viewport widths #275

Closed Toutouwai closed 5 years ago

Toutouwai commented 6 years ago

There seems to be an issue where margins are not consistent at narrow viewport widths. Images with a wide aspect ratio in particular seem to be affected.

You can observe the issue in the Justified Gallery demo. In the screencast below note how the top margin becomes incorrect (doubled?) on the "mountain road" image at a particular viewport width.

justified

I could reproduce the issue in both Chrome and Firefox, Windows 10.

acwolff commented 6 years ago

It is a pity that I can’t see what the scrollbars are doing, because the problem is related to the showed/disappeared scrollbar(s). I think too you should tell us what the values are of the refreshSensitivity, the border and the margins. A link to your album should also be helpfull.

Toutouwai commented 6 years ago

@acwolff, as I said above, the issue is observable in the Justified Gallery demo: http://miromannino.github.io/Justified-Gallery/

ghost commented 6 years ago

I've also had the same problem for a long time and tired to hide it with a small margin, so it wouldn't be that noticeable. It would be wonderful if this bug could be fixed, as it's quite annoying.

fireform commented 6 years ago

+1

Brodiero commented 5 years ago

+1

dandan commented 5 years ago

PR #286 fixed this for me too.