Fix waitThumbnailsLoad option

miromannino / Justified-Gallery

Javascript library to help creating high quality justified galleries of images. Used by thousands of websites as well as the photography community 500px.

http://miromannino.github.io/Justified-Gallery/

MIT License

1.68k stars 299 forks source link

Fix waitThumbnailsLoad option #297

Closed sc0ttman closed 5 years ago

sc0ttman commented 5 years ago

waitThumbnailsLoad Is for building the grid before the images have been loaded. We cannot use $.prop() before the image is loaded as it will return 0. We must use the attributes the user has rendered into the elements.

Width and Height props are 0 so the gallery will not render
We need to specifically use attr() for width/height data

mfg92 commented 5 years ago

These small changes worked for me, thank you @sc0ttman!

miromannino commented 5 years ago

Thank you @sc0ttman for spotting this bug! Can you please try to do these quick changes on the latest code version so I can merge them? It's just to attribute to you the changes, otherwise I would do it quickly