search

miromannino / Justified-Gallery

Javascript library to help creating high quality justified galleries of images. Used by thousands of websites as well as the photography community 500px.
http://miromannino.github.io/Justified-Gallery/
MIT License
1.68k stars 299 forks source link

Last row centering now far worse than in 3.7.0 #329

Closed jefftucker1952 closed 4 years ago

jefftucker1952 commented 4 years ago

Alas, this problem, which my little patch seemed to fix, is now much worse in 3.8.0. The demo:

(demo removed - 3.8.1 appears to fix the problem)

Try changing the viewport width. What you'll see is something like this:

lastrow380

The one-pixel error is back (at right), and now there are some new unwanted artifacts. The culprit appears to be the changes to lines 187-8 in this commit, but I haven't tested yet:

https://github.com/miromannino/Justified-Gallery/commit/e11144276b5da15b94af4360253068342510fe8b

ETA: Confirmed. With those two lines restored to their 3.7.0 selves, the behavior is once again correct.

miromannino commented 4 years ago

Oh no! I also changed these because I thought they would cause similar issues.

Can you try updating to 3.8.1?

jefftucker1952 commented 4 years ago

Yes, that's more like it. It's those last-minute changes that sneak up and bite you. I know about those! ;)

I'm prepping a bunch of updates to my packages that use JG, so I'll incorporate 3.8.1, which will give it a good workout. I'll post back if any new problems crop up. There's one left over from 3.7.0, involving fixed shape thumbnails, but I'll start a new issue, with an updated demo - it's tiny, and it's a fringe case.

miromannino commented 4 years ago

Perfect! :)