search

miromannino / Justified-Gallery

Javascript library to help creating high quality justified galleries of images. Used by thousands of websites as well as the photography community 500px.
http://miromannino.github.io/Justified-Gallery/
MIT License
1.68k stars 299 forks source link

Captions not working #330

Closed jefftucker1952 closed 4 years ago

jefftucker1952 commented 4 years ago

Captions in 3.8.1 are not working. Compare these two pages - the only difference between them is the version of JG:

(demo's removed)

The captions appear on mouseover in 3.7.0, but not in 3.8.1.

jefftucker1952 commented 4 years ago

A little hunting in the source code reveals what I believe is the solution:

<div class='jg-caption'>The Caption</div>

Have I got that right? Does anything else have to be changed?

A sensible change, since a class of just caption is pretty generic.

miromannino commented 4 years ago

Yes exactly, not anymore caption, but jg-caption. It was renamed because it's likely that the beginners are going to have CSS that is polluting all elements with class caption, so they cause bugs on JG. It'a already in the list of changes, but I'll change also the documentation for this.

Thank you for mentioning