selector option div:not(#some_id) neglected

miromannino / Justified-Gallery

Javascript library to help creating high quality justified galleries of images. Used by thousands of websites as well as the photography community 500px.

http://miromannino.github.io/Justified-Gallery/

MIT License

1.68k stars 299 forks source link

selector option div:not(#some_id) neglected #340

Open git-marijus opened 4 years ago

git-marijus commented 4 years ago

I am using jquery version 3.5.1 and justifiedGallery version 3.8.1

When using div:not(#some_id) in the selector options, the div with said id will still be turned into an gallery item which results in display errors.

jefftucker1952 commented 4 years ago

Works when I do it (same versions of jQuery and JG), so I think we'll need to see an example.

EDIT: Ah, you are correct! It works properly with JG 3.7.0, but not with JG 3.8.1.

git-marijus commented 4 years ago

Thanks for confirming!

jefftucker1952 commented 3 years ago

I'm really sorry to see that a bug as obvious as this hasn't been addressed for over 5 months. This script appears to be abandonware, I'm afraid.

alexanderhasan commented 11 months ago

You can put the class "jg-spinner" div:not(.jg-spinner) also in your elemnent, thats work for me :)

jefftucker1952 commented 11 months ago

You're right - that does work!

Leave a problem kicking around for about three years, and no one will determine how to fix it, but someone will come up with a perfectly acceptable workaround. ;)