search

mironal / TwitterAPIKit

Swift library for the Twitter API v1 and v2 🍷
MIT License
121 stars 25 forks source link

Remove the API protocol and make it a class instead. #127

Closed mironal closed 2 years ago

mironal commented 2 years ago

We chose to use classes for the following reasons.

Protocols are not scalable.

Protocols make it difficult to write extensions such as RxSwift's Reactive.

codecov-commenter commented 2 years ago

Codecov Report

Merging #127 (4768f0e) into main (5e647ab) will decrease coverage by 6.79%. The diff coverage is 6.66%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   87.11%   80.32%   -6.80%     
==========================================
  Files         254      255       +1     
  Lines        6241     6805     +564     
==========================================
+ Hits         5437     5466      +29     
- Misses        804     1339     +535
Impacted Files Coverage Δ
...ces/TwitterAPIKit/APIv1/Account/AccountAPIv1.swift 0.00% <ø> (ø)
...terAPIKit/APIv1/Application/ApplicationAPIv1.swift 0.00% <0.00%> (ø)
...rAPIKit/APIv1/BlockAndMute/BlockAndMuteAPIv1.swift 0.00% <ø> (ø)
...itterAPIKit/APIv1/Collection/CollectionAPIv1.swift 0.00% <ø> (ø)
...PIKit/APIv1/DirectMessage/DirectMessageAPIv1.swift 0.00% <0.00%> (ø)
...s/TwitterAPIKit/APIv1/Favorite/FavoriteAPIv1.swift 0.00% <ø> (ø)
...terAPIKit/APIv1/Friendships/FriendshipsAPIv1.swift 0.00% <ø> (ø)
Sources/TwitterAPIKit/APIv1/Geo/GeoAPIv1.swift 0.00% <ø> (ø)
Sources/TwitterAPIKit/APIv1/Help/HelpAPIv1.swift 0.00% <ø> (ø)
Sources/TwitterAPIKit/APIv1/List/ListAPIv1.swift 0.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e647ab...4768f0e. Read the comment docs.