search

mironov / react-redux-loading-bar

Loading Bar (aka Progress Bar) for Redux and React
https://mironov.github.io/react-redux-loading-bar/
MIT License
936 stars 93 forks source link

[Question] Does this support the react-redux@6.0.0? #83

Closed franklixuefei closed 5 years ago

franklixuefei commented 5 years ago

I asked because in the latest react-redux specs, it mentioned that

Any library that attempts to access the store instance out of legacy context will break, because we now put the store state into a <Context.Provider> instead.

franklixuefei commented 5 years ago 
react-redux-loading-bar@4.1.0 requires a peer of react-redux@^3.0.0 || ^4.0.0 || ^5.0.0 but none is installed
mironov commented 5 years ago

@franklixuefei Good question. I think the Loading Bar doesn't support the latest Redux yet. I'll try to find time to release an updated version this week.

mironov commented 5 years ago

@franklixuefei Turned out that react-redux@6.0.0 doesn't change the connect API and the line you quoted is related to libraries that pull the store out of the context. Loading Bar never did that so I bumped the dependency in v4.2.0.

I also updated the demo to the latest versions: https://mironov.github.io/react-redux-loading-bar/ Source code of the demo is at: https://github.com/mironov/react-redux-loading-bar/tree/gh-pages

franklixuefei commented 5 years ago

Thanks you!

On Jan 10, 2019, at 4:27 AM, Anton Mironov notifications@github.com wrote:

@franklixuefei Turned out that react-redux@6.0.0 doesn't change the connect API and the line you quoted is related to libraries that pull the store out of the context. Loading Bar never did that so I bumped the dependency in v4.2.0.

I also updated the demo to the latest versions: https://mironov.github.io/react-redux-loading-bar/ Source code of the demo is at: https://github.com/mironov/react-redux-loading-bar/tree/gh-pages

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.