search

mironov / react-redux-loading-bar

Loading Bar (aka Progress Bar) for Redux and React
https://mironov.github.io/react-redux-loading-bar/
MIT License
936 stars 93 forks source link

Fix memory leaks caused by multiple start calls #87

Closed art5255 closed 4 years ago

art5255 commented 5 years ago

if start called multiple times should clear previous interval to avoid memory leak

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.04%) to 98.958% when pulling 264e6982f6d0d466e04ef7bc411f9f1e5060e2f5 on art5255:master into 6632b492de9c807295c22f4a4cf6ec611f38e83a on mironov:master.

mironov commented 5 years ago

@art5255 Thank you for the PR. Any idea of how several sequential calls of start() could happen? I wonder if a test can be written for the case.

mironov commented 4 years ago

I think I fixed a possible case when start() could be called twice resulting in leaking progressInterval in https://github.com/mironov/react-redux-loading-bar/commit/832727cde31d4a52e2e6b29fd7a2223912fedd51 I'm going to close this PR for now.

Feel free to rebase and reopen it if the issue still persists in >= v4.5.0