miroslavpejic85 / mirotalk

🚀 WebRTC - P2P - Simple, Secure, Fast Real-Time Video Conferences Up to 8k and 60fps, compatible with all browsers and platforms.
https://p2p.mirotalk.com
GNU Affero General Public License v3.0
3.03k stars 558 forks source link

Allow Permission is Not Showing #13

Closed sajalsoumalya closed 3 years ago

sajalsoumalya commented 3 years ago

https://mirotalk.herokuapp.com/ When I am Trying to Join any Room It Should Ask For Microphone and camera permission But It is Not Asking

Again and again it is Giving Access Denied

Please Help me

I am attaching The Screen Shot Of It Screenshot (13)

miroslavpejic85 commented 3 years ago

Hi @livingloves, welcome! Maybe you didn't give permission the first time by mistake, try this Both for Camera and Microphone.

image

Then restart your browser.

As for the TRY AGAIN button, scroll slightly down your page and it should appear.

Jaideep25 commented 3 years ago

@miroslavpejic85 actually in some cases, this doesn't show up because you can block access to camera system wide so it doesn't show the pop-up... @livingloves try to check whether you have blocked camera and microphone system wide! Thanks!

miroslavpejic85 commented 3 years ago

@Jaideep25 I added that the getUserMedia error type is displayed: https://github.com/miroslavpejic85/mirotalk/commit/3f8d04f5bfc5b7ca2d10fb08606a67307be62a5d

getUserMediaError

At the end it's not a mirotalk problem 🙂

Jaideep25 commented 3 years ago

Yup xD, more cool! 😋

Extarys commented 3 years ago

Should it work if I only have a microphone plugged in? I'm with some folks on a Mozilla channel and we are trying to figure out what is going on. Some people say it works, some don't.

I understand this might not be a mirotalk issue but any help to make this work is welcome.

Jaideep25 commented 3 years ago

Hey @Extarys welcome! Actually mirotalk needs both audio and webcam, otherwise it doesn't work, please do check if you have disabled webcam and mic access systemwide or your browser... Thanks! Hope it helps!

Extarys commented 3 years ago

Thanks! I don't have a webcam so that is the problem - cat ate the wire. Also the error is "The request is not allowed by the user agent or the platform in the current context.". Could we change the error so it's a little bit more precise? I've been troubleshooting my firefox setup for at least an hour :stuck_out_tongue_closed_eyes:

EDIT: I'm sorry, I had privacy.resistFingerprinting enabled in Firefox. My original error was: image

From #media:mozilla.org:

With privacy.resistFingerprinting enabled, we never fail with NotFoundError since this would give the site bits of information about your system to fingerprint you, and fail with NotAllowedError instead. That's why miratalk thinks you have both but haven't enabled them (it doesn't know you don't have both)

Jaideep25 commented 3 years ago

Ah sad to know that your cat ate up the wire 😂😂, I'll let @miroslavpejic85 know about the enhancement! ;)

miroslavpejic85 commented 3 years ago

Hey @Extarys welcome! 🙂 So your cat has eaten the webcam wire and mirotalk won't start? 😅 As for the error you see on that page after Access Denied, It's not writed by me, but it's the getUserMedia Api error if something wrong as you can see here: https://github.com/miroslavpejic85/mirotalk/blob/master/www/js/client.js#L1365 . I can improve that to not print only the error.message but all the error maybe it's better ... Here you can found the common getUserMedia errors: https://blog.addpipe.com/common-getusermedia-errors/ Which maybe can help someone understand the problem caused by the error. As @Jaideep25 said you need to have both Video and Audio enabled correctly on your devices to makemirotalk work properly. 😉

miroslavpejic85 commented 3 years ago

Done: https://github.com/miroslavpejic85/mirotalk/commit/62d4a66ab426bc0f1515e79c548c6b54cddb5c60

miroslavpejic85 commented 3 years ago

@Extarys @Jaideep25 Do I have to do something else for this task or do we close it? 🙂

Jaideep25 commented 3 years ago

Nope you can close it! Problem was solved!