Screensharing and Raise hand

miroslavpejic85 / mirotalk

🚀 WebRTC - P2P - Simple, Secure, Fast Real-Time Video Conferences Up to 8k and 60fps, compatible with all browsers and platforms.

https://p2p.mirotalk.com

GNU Affero General Public License v3.0

3.03k stars 558 forks source link

Closed Jaideep25 closed 3 years ago

Jaideep25 commented 3 years ago

Hi @miroslavpejic85 ! As you had told I have made the issue, some modifications you can do as follows!

Could you please do something like, when you screenshare, and turn your video off, the screen share should still work, and the video shouldn't turn on, when you stop sharing.
And when you raise your hand the video should get highlighted, because, if someone's video's bg is green, and when they raise their hand, it won't be seen clearly.

Hoping you can add these in your code! Waiting for your reply! Regards.

miroslavpejic85 commented 3 years ago

Hi @Jaideep25. Thanks for the tips. I'll improve that part.

miroslavpejic85 commented 3 years ago

@Jaideep25 - For the raise hand, I added the black background, pulsate effect, and sound notification: https://github.com/miroslavpejic85/mirotalk/commit/c13f1b867dd14420157624af007d77ab0e5d8146

Jaideep25 commented 3 years ago

Woah amazing!! You're really amazing!

miroslavpejic85 commented 3 years ago

@Jaideep25 - For the screen sharing, i solved in this way: https://github.com/miroslavpejic85/mirotalk/commit/fa92415ca639ee6aebae2fe4464a6bdde5ad0bed Just click to video OFF button, before to stop a screen sharing, then you will be return on webcam but with video OFF.

Jaideep25 commented 3 years ago

Oh not bad! You're clever!

rudrathedev commented 3 years ago

Epic sir @miroslavpejic85 😊

Jaideep25 commented 3 years ago

Ikr! So, I can close the comment? @miroslavpejic85