search

miroslavpejic85 / mirotalk

🚀 WebRTC - P2P - Simple, Secure, Fast Real-Time Video Conferences Up to 4k and 60fps, compatible with all browsers and platforms.
https://p2p.mirotalk.com
GNU Affero General Public License v3.0
2.6k stars 502 forks source link

Webcam disabling when video button is turned off #186

Closed HariKrishna-28 closed 7 months ago

HariKrishna-28 commented 7 months ago

Fixes #152

Fixes the issue by adding a function that disables the tracks that gets called when myVideoStatus is false

HariKrishna-28 commented 7 months ago

Hello @miroslavpejic85! I have made the necessary changes as you've asked and please let me know if something needs to be changed.

Thank you and have a good day!

miroslavpejic85 commented 7 months ago

Hello @miroslavpejic85! I have made the necessary changes as you've asked and please let me know if something needs to be changed.

Thank you and have a good day!

Hi, As previously mentioned, it is imperative that we conduct further testing to ensure that everything is functioning optimally. If you have time to delve deeper into the project and address the issue, that would be greatly appreciated. However, if your schedule does not permit it at the moment, I am prepared to tackle it when I have more availability.

For example, when you share your screen and then press stop sharing screen button, it doesn't seem to bounce back to the camera. It could be a side effect of the change made and so on....

Thank you for your understanding and have a good day too.

miroslavpejic85 commented 7 months ago

For example, when you share your screen and then press stop sharing screen button, it doesn't seem to bounce back to the camera. It could be a side effect of the change made and so on....

Fixed in master, not related to this changes.

miroslavpejic85 commented 7 months ago

Check out the updated snippet, please merge the branch with the latest Mirotalk master. Try some thorough cross-testing, but if you happen to come across any issues, please don't hesitate to get in touch with me. From what I quickly tested, the LED light seems to turn off correctly when the track video is stopped and vice versa, but everything else needs to be tested if it doesn't break something.... Thank you and I wish you a fantastic day!

miroslavpejic85 commented 7 months ago

I'm going to close this for now as we need to review the code. There have been some significant changes, and I'd appreciate it if you could send me an updated PR. Thank you so much for your help and understanding. Your contributions are greatly appreciated!