search

miroslavpejic85 / mirotalk

🚀 WebRTC - P2P - Simple, Secure, Fast Real-Time Video Conferences Up to 4k and 60fps, compatible with all browsers and platforms.
https://p2p.mirotalk.com
GNU Affero General Public License v3.0
2.59k stars 502 forks source link

new audio streams are not added to recording #200

Closed mohan43u closed 5 months ago

mohan43u commented 5 months ago

Describe the bug

When we start recording, we have two people. while recording is going on, one more person join. We expect that the new person's audio is also gets recorded, but only audio from the people who were present during start of the recording gets recorded.

To reproduce

  1. Have two people start a recording
  2. Ask someone new to join to the same room
  3. the newly joined person's audio is not recorded

Expected behavior

The newly joined person who joined after we start recording should also be captured

Desktop - Mobile

Please complete the following information:

miroslavpejic85 commented 5 months ago

Hello @mohan43u,

It appears that including additional audio streams during a recording is not feasible with the current design of the MediaRecorder API.

Typically, the process involves stopping the ongoing recording, creating a new MediaRecorder instance with the updated set of audio streams, and then initiating a new recording.

This limitation is inherent in the MediaRecorder API's structure.

For more in-depth discussions and collaborative problem-solving, I recommend using our community forum instead of opening issues here.

You can join our community forum, where we can engage in collective discussions and address any concerns before proceeding.

Thank you for your understanding.