search

miroslavpejic85 / mirotalk

🚀 WebRTC - P2P - Simple, Secure, Fast Real-Time Video Conferences Up to 8k and 60fps, compatible with all browsers and platforms.
https://p2p.mirotalk.com
GNU Affero General Public License v3.0
3.03k stars 558 forks source link

MCU - SFU architecture #35

Closed miroslavpejic85 closed 3 years ago

miroslavpejic85 commented 3 years ago

Mirotalk has no a intermediate media server for audio - video communication, they are pure peer to peer connections between browsers, therefore it requires a good Bandwidth - CPU.

The current WebRTC Mesh architecture is not optimal for conferences with more than 6-8 users in the same room. The quality of the call is inversely proportional to the number of people on the call. The approximative users supported in a single room should be around 6-8 in an average high-speed connection.

The goal is to have a support media server and adapt the current architecture to MCU (MultiPoint Control Unit) or SFU (Selective Forwarding Unit). To have more users connected in the same room, consuming less bandwidth!

mirotalk-mesh

Any idea, best solution, contributions to reach this goal is very appreciated! ❤️

Thank you so much to all those who believe in this project and who support me!

ghost commented 3 years ago

Hello, @miroslavpejic85 !

miroslavpejic85 commented 3 years ago

Hi @vcdev87, welcome! 🙂

ghost commented 3 years ago

Welsome also to you @miroslavpejic85 ! :) When is timeline for this feature? 🚀 🎸

miroslavpejic85 commented 3 years ago

I created this issue to collect ideas, suggestions, etc. on what could be the best solution to achieve this goal. 🏆 Obviously, the collaborators are also welcome. 😎

ghost commented 3 years ago

Obviously, the collaborators are also welcome. 😎

I forgot to mention that 🤒

How many collaborators working on this now, and is there space for more? 💥 🥇 💯

miroslavpejic85 commented 3 years ago

Currently, about 98% of the code is done by me, look on commits, I've had a couple of pull requests which are highly appreciated ❤️ and of course anyone who wants to contribute to this project are welcome! 😇

ghost commented 3 years ago

Currently about 98% of the code is done by me

Wow, very good @miroslavpejic85 🕺 🎉 , but also the

  1. collaborators

did good job with the 2% of the code.

Is anyone collaborator working on MCU - SFU now? Maybe space for more collaborators on MCU - SFU ? 🌕 🚀 🎸

Together we can do this 💪

miroslavpejic85 commented 3 years ago

In my spare time, I'm looking for the possible solutions, but I would like to have some suggestions here as well. 🙂 Yeah, Alone we walk fast, but together we go far.... 💪

ghost commented 3 years ago

How much time you estimate for this to be implemented! 🚀 🤖 I want to have 100 and 100 of people, friends, family and collaborators in same room at once 🎂

Individual commitment to a group effort--that is what makes a team work, a company work, a society work, a civilization work.

miroslavpejic85 commented 3 years ago

I want it too! 🙂 As for the implementation, I can't tell you exactly how long it will take. I'd also like to create discussions about it here.

ghost commented 3 years ago

How do you think I should start to fix this right now? 💯 💵

miroslavpejic85 commented 3 years ago

Studying a bit how the WebRTC works, the current mirotalk code, and looking for possible and best solutions to get to the goal. 🙂 💪 We never stop learning. This is why sharing experiences, suggestions, collaborating, I think Its more constructive for everyone than doing it all by yourself. If someone wants also to contribute to the code with PR, they will always be welcome! ❤️

ghost commented 3 years ago

hi @miroslavpejic85 ! Thank you very much 🥮 What I wantedto know is can I fix this right now? Maybe

  1. YOU 2. Could tell
  2. Me how I can start to implement MCU - SFU right now.

This way we will have bigger meetings with more participants, and everyone will be happy 🤯 💯 👍 To me, teamwork is the beauty of our sport, where you have five acting as one. You become selfless. !!!!

ghost commented 3 years ago
  1. Is this fixed @miroslavpejic85 ?
miroslavpejic85 commented 3 years ago

No, I'm just collecting some information around concerning the available SFU servers...

ghost commented 3 years ago

@miroslavpejic85 When will this bugs be

  1. Done? 🚀

Timeline?. OFC i am contribrutor and will help 🤣 🚀 🎸

miroslavpejic85 commented 3 years ago

Hi @vcdev87 ! I remind you that I also have a job (8h x day), on mirotalk I put my hand in free time!

The code is open source, if you are able to adapt it to an SFU architecture, work on it!, and then let's see the PR ... instead of asking when it will be done - timeline etc!

There is no need to specify certain things, the others can see who are you!

And if I can just ask you the courtesy to not spam too much with self-made emoji reactions. Let others interact. I hope you understand me. Thank you so much and have a nice day.

And just for information, it's not a Bug, but a limitation of the Mesh architecture I've already described. ;)

image

Regards

miroslavpejic85 commented 3 years ago

No, I'm just collecting some information around concerning the available SFU servers...

And I don't understand this reaction 👎 ? We need to have respect for those who work on open source in general, and for those who give you the opportunity to use it for free! Doing research etc., it seems to me a positive thing, and in my free time I try to improve the project that's all ;)

ghost commented 3 years ago

@miroslavpejic85 .

I am SORRY for me pushing too much. Sometimes I want too much. I am very HAPPY with

  1. you and
  2. contributrotrs on this project ❤️

Have a nice DAY

ghost commented 3 years ago

Hi @miroslavpejic85 18 days was last comment on this bug.
As promised will check STATUS on issues when I have time. Can we

  1. CONTRIbrurtors get STATUS update on this? 💤 🥇 🙄 🚀

Coming together is a beginning. Keeping together is progress. Working together is success.

ghost commented 3 years ago

@miroslavpejic85 🆘 🆘 🆘 !!!! Any news? 🥎 I performance tested now and still not possible with more then

  1. 5-6 PEERS in same room!! 🥉 🔢
pragmatech commented 3 years ago

Hi, Thanks for sharing this. I've been slogging through WEBRTC and its challenges for a while and your implementation is really nice (i.e. works well). Fwiw, having a toggle, to sharescreen w/ audio, would open up some nice mutual streaming, I'd think. Anyway, as a caveman dev, I might not be able to offer much; however, it seems that, in the SFU-area, that the Mediasoup server is really backing some of the current robust webrtc implementations.

ghost commented 3 years ago

Hi @pragmatech , welcome 😃 THANKS for feedback. I think maintainer

  1. @miroslavpejic85 is no longer working on this bug 🆘 🆘 . And in future only 3-5 people can be in same room at ONCE. But latency will be better with peer to peer then SFU at least 🎸
Jaideep25 commented 3 years ago

@vcdev87 May I know from where did you get this INFORMATION that @miroslavpejic85 isn't working on this? And it's a enhancement feature not a bug for your information, you can even see the tags put up.....

miroslavpejic85 commented 3 years ago

Hi @pragmatech. I'm very happy you like MiroTalk. Thanks for the tips! :)

ghost commented 3 years ago

Hi @Jaideep25 ! You can SEE from comments above that NO answers is provided by maintainer on my DEMANDS. Therefore

  1. I think progress has stopped! 🆘 🆘 🎸 🤣
Jaideep25 commented 3 years ago

To see the progress i guess you can see the commits, and their is nothing to laugh! Please don't check on his progress, he's even seeing other problems with RTCDataChannel which I guess you din't see today's commit... Please don't say anything until you don't know.... and I guess if you're behind a person, he/she will ignore you.... Thanks!

ghost commented 3 years ago

THanks for clarification @Jaideep25 ! I appreciate

miroslavpejic85 commented 2 years ago

Done: https://github.com/miroslavpejic85/mirotalksfu