miroslavpejic85 / mirotalk

🚀 WebRTC - P2P - Simple, Secure, Fast Real-Time Video Conferences Up to 8k and 60fps, compatible with all browsers and platforms.
https://p2p.mirotalk.com
GNU Affero General Public License v3.0
3.03k stars 558 forks source link

Error: port is undefined #48

Closed Salamafet closed 3 years ago

Salamafet commented 3 years ago

Hi,

I run mirotalk behind a reverse proxy with docker-compose. When I start a meeting, I don't have the video and the sound of the other participant.

In the console of browser, I have this error every 100 milliseconds ~ : Error: port is undefined.

What am I doing wrong ?

miroslavpejic85 commented 3 years ago

Hi @Salamafet, welcome! Could you show me the whole error in the console? A screenshot is fine too. Have you changed the code? Thanks.

Salamafet commented 3 years ago

Hi and thanks for your time

Here is a screenshot of Firefox Console: Firefox_2021-07-05 20-07-18

I have modified a bit of HTML and JS for translating a part of mirotalk.

In the docker compose file, I have changed the port binding because Synology services already use the 3000 port.

ports:
      - "8088:3000"

Is the problem here ?

miroslavpejic85 commented 3 years ago

Ok no problem, try this: https://github.com/miroslavpejic85/mirotalk/blob/master/server.js#L52 Instead of 3000 change to 8088 https://github.com/miroslavpejic85/mirotalk/blob/master/www/js/client.js#L69 Instead of 3000 change to 8088 https://github.com/miroslavpejic85/mirotalk/blob/master/docker-compose.yml#L15 Instead of 3000:3000 change to 8088:8088

Then rebuild the images

docker-compose build
docker-compose up

Let me know if ok ;)

PS: If you have run mirotalk on a different PC than yours, take a look at this too: https://github.com/miroslavpejic85/mirotalk/issues/36#issuecomment-860268124, using ngrok you will be able to access it from any local-remote device.

Salamafet commented 3 years ago

I have already tried to change the port in those files unsuccessfully.

Has explained, I use a reverse proxy. The reverse proxy connects to the container on port 8088 but his listening on port 80/443 (HTTP redirect to HTTPS).

I have tried to redirect the port 8088 directly on the container, but I'm not certain if I can use reverse proxy plus direct.

EDIT: I don't have trying to rebuild. I try this as soon as possible.

miroslavpejic85 commented 3 years ago

And that I haven't tried it in that scenario in order to tell you exactly what the problem may be. But try again with the changes you made but remember that every change you make to mirotalk stop it rebuilds the image so it takes your changes and run it again. Let me know if you're stuck yet?

Salamafet commented 3 years ago

Still have the error, but it's working now. I can hear and see other participants.

I do not have redirected the 8088 port from my router on my container. I don't understand how mirotalk exactly works, but it's works.

Thanks :)

miroslavpejic85 commented 3 years ago

Good news! Thanks to you. ❤️ So, network configuration issue.