search

miroslavpejic85 / mirotalksfu

🏆 WebRTC - SFU - Simple, Secure, Scalable Real-Time Video Conferences Up to 8k, compatible with all browsers and platforms.
https://sfu.mirotalk.com
GNU Affero General Public License v3.0
2.15k stars 340 forks source link

Room host can't rejoin in lobby #123

Closed DezyNation closed 1 year ago

DezyNation commented 1 year ago

Describe the bug

If lobby mode is enabled and the host somehow gets disconnected, he is not able to join back because there is no one to accept his joining request

To Reproduce

Steps to reproduce the behavior:

  1. Start a room
  2. Enable Lobby mode
  3. Refresh your page to leave the room and join back
  4. See the issue

Expected behavior

Created room's data should be stored temporarily in system along with it's host's data (it could be a unique identifier that can be given to each user or the device's IP address or anything else). Whenever the host tries to join, he should be able to join even if the room is password protected or lobby enabled. This problem can also be solved by providing a feature to assign some users as co-host who can manage joining requests.

Desktop - Mobile

miroslavpejic85 commented 1 year ago

Hi @DezyNation, The unique id for the presenter (host) and participants is given by his username (unique per room) and his uuid (unique per user), so when rejoining the room as presenter (host) make sure you put the same username he had previously. The bug should be fixed with a small server-side change, see the commit. Thank you!