miroslavpejic85 / mirotalksfu

🏆 WebRTC - SFU - Simple, Secure, Scalable Real-Time Video Conferences Up to 8k, compatible with all browsers and platforms.
https://sfu.mirotalk.com
GNU Affero General Public License v3.0
2.15k stars 340 forks source link

Keep room name through authentication #124

Closed rawtaz closed 1 year ago

rawtaz commented 1 year ago

Feature request

Currently, if you have an instance where one has to supply username and password (configured in the settings of MiroTalk) to access it, and a non-authenticated visitor access the instance using a link such as https://my.instance/join/myroom or https://my.instance/join?room=myroom with the intent of ending up in a specific room right away, they don't end up in that room because of the user authentication. They arrive at the authentication page, and after that they arrive at the page where they have to enter a room name to enter.

I would like for MiroTalk to keep track of which room was requested as part of the link, and after the visitor entered valid username and password, instead of providing them with the page where they enter a room name in a text field, directly put them in the starting page for entering that URL-specified room (of course still entering a name to use in the meeting).

Pros

This would let you share simple links with other parties, where instead of them having to manually enter the room name you already provided in the link, they arrive directly into the meeting (having to enter only their name, after clicking your link). This is very useful when inviting people who just want to start talking with you. There's little point in having them enter the room name when you already put it in their link.

Additional context

MiroTalk SFU is such an amazing piece of software, well written and well designed! ❤️

miroslavpejic85 commented 1 year ago

Done!

If host protection enabled, the proposed enhancement is to make it more user-friendly by allowing the sender of the meeting link to specify the room name in the link itself. When someone clicks on such a link, they would still need to enter their username and password for authentication, but after successfully authenticating, they would be directed to the specified room automatically, without having to manually enter the room name in the landing page as now.

Here's what this feature would achieve:

Pros:

  1. Simplified User Experience: Users receiving the link don't need to type in the room name manually, reducing the chances of errors and making it quicker to join a specific room.

  2. Streamlined Invitations: When inviting people, you can send them a direct link to the meeting room they need to join, making the invitation process more straightforward.

  3. Efficiency: Especially useful when inviting people who just want to start talking with you, as they can click the link and get into the meeting with minimal effort.

In summary, this feature request aims to improve the user experience by reducing the steps required to join a specific room in MiroTalk on host protection enabled, making it more convenient for both the sender of the link and the recipient.

Note The authentication logic remains the same, but after the host authentication, it joins directly into the room if specified in the URL, same for the participants (who does not need to authenticate again since the host has already done so).

Here the valid link as example for direct room join after host authentication if host protection enabled:

PS: I'm glad to hear that you find MiroTalk SFU to be amazing! It's great to know that you appreciate its quality and design. Thank you for your feedback!