miroslavpejic85 / mirotalksfu

🏆 WebRTC - SFU - Simple, Secure, Scalable Real-Time Video Conferences Up to 8k, compatible with all browsers and platforms.
https://sfu.mirotalk.com
GNU Affero General Public License v3.0
2.15k stars 340 forks source link

Opening links from the chat kicks you out of the meeting #168

Closed avatar1024 closed 1 month ago

avatar1024 commented 1 month ago

Describe the bug

If some one put a link in the chat, the when clicking on a link in the chat, the link loads on the same page of the meeting and so I get kicked out of the meeting. The default behaviour should be to open links in a new window.

Tested with Firefox, MiroTalk SFU 1.5.83 (Cloudron)

Steps to reproduce

  1. Create a meeting room
  2. Have someone join the room
  3. Open the chat window
  4. Post a link to a webpage
  5. Click on the link

Expected behavior

The link open in a new window

Device

Browser

Relevant log output

No response

Reproducibility

Yes

Additional context

No response

bitkarrot commented 1 month ago

I managed to fix this in our forked code base for firefox but it still seems to persist on Brave browser. Unclear why.

miroslavpejic85 commented 1 month ago

Hi @avatar1024, Thank you for bringing this to our attention. The issue has been addressed and resolved in the attached commit.

miroslavpejic85 commented 1 month ago

mirotalk-sfu-fix-target