miroslavpejic85 / mirotalksfu

🏆 WebRTC - SFU - Simple, Secure, Scalable Real-Time Video Conferences Up to 8k, compatible with all browsers and platforms.
https://sfu.mirotalk.com
GNU Affero General Public License v3.0
2.15k stars 340 forks source link

Auto-detection of external IP #87

Closed hoewer closed 1 year ago

hoewer commented 1 year ago

Feature request

I would appriciate if your sfu-branch could gather the external IP (announcedIp) automatically. SOHOs often have dynamically assigned IPs - and it is quite annoying to adapt the configuration every time the IP changes. For your other branches (c2c/p2p) Coturn (or other TURN-servers) are performing this job. It would be either possible to use Coturns approach (using an external shell-script) or implement it via node.js. For my purposes a poll when starting the software/container (I'm running it in docker) would be sufficient. However, it might also be useful to perform this every time a new room is set up.

Additional context

Samples on the Web look like:

var http = require('http');

http.get({'host': 'api.ipify.org', 'port': 80, 'path': '/'}, function(resp) {
  resp.on('data', function(ip) {
    console.log("My public IP address is: " + ip);
  });
});
miroslavpejic85 commented 1 year ago

Hello @hoewer, If announcedIp: '' will be auto-detected now ;) Thank you for your feedback!

hoewer commented 1 year ago

Thank you for your incredibly fast implementation. You don't have a life besides Mirotalk? ;-) It works like charm. BTW: Very nice project. I love it. I use it for family communications and prefer it to alternatives with commercial background or uncertain security .

miroslavpejic85 commented 1 year ago

You are welcome! I work for a company full time, and maintain MiroTalk in my spare time :) I'm very happy to receive your positive feedback! Thank you and have a good weekend.