miroslavpejic85 / mirotalkwebrtc

🛠 MiroTalk's WebRTC rooms scheduler.
https://webrtc.mirotalk.com
GNU Affero General Public License v3.0
264 stars 50 forks source link

Incorrect volume in mongodb service in docker-compose.template.yml #1

Closed BackedUpBooty closed 1 year ago

BackedUpBooty commented 1 year ago

Currently you've got the following in mongodb:

    volumes:
      - './.mongodb_data:/data/db'

however as you're creating a named volume later in the compose file it should be as follows:

    volumes:
      - mongodb_data:/data/db
miroslavpejic85 commented 1 year ago

Hey @BackedUpBooty, it's like a hidden folder, still working anyway.

BackedUpBooty commented 1 year ago

Not really. When docker creates a volume, it's put into the /var/lib/docker/volumes directory, or some variant (dependent on the system you have it on). The way you've set up volumes means docker will look for a file called .mongodb_data inside the same directory that the compose file lives in. Those aren't always going to be the same.

miroslavpejic85 commented 1 year ago

The way you've set up volumes means docker will look for a file called .mongodb_data inside the same directory that the compose file lives in.

Yeah, it is intentionally so for my use case.

Those aren't always going to be the same.

I agree, but being now a template file, which is copied and edited at will, it shouldn't be a problem, as everyone can adjust it to their needs.

Thank you!