search

mirovit / nova-notifications

66 stars 26 forks source link

Notification diffForHumans translated #23

Closed newtongamajr closed 3 years ago

newtongamajr commented 3 years ago

Hi @mirovit,

First of all, thank's for your great and amazing package!

I'd like to suggest that when presenting the diff for humans from the created_at, to use Laravel Locale configured. This way users should read this in their native language!

Best regards! Captura de tela 2021-01-28 150339

mirovit commented 3 years ago

Hi @newtongamajr,

Thank you for the feedback. This actually has been brought up before - I don't think that the package should be responsible for setting the application locale, it should be done on app level. I think this is something that needs to be added to the README file.

Here's the solution - https://github.com/mirovit/nova-notifications/issues/5#issuecomment-616490916

Hope this helps you! Let me know if you need more information.