mirrexagon / nixpkgs-esp-dev

Nix flake and overlay for ESP8266 and ESP32 development.
Creative Commons Zero v1.0 Universal
145 stars 72 forks source link

feat: add support for RISCV32 toolchains #8

Closed RaitoBezarius closed 2 years ago

RaitoBezarius commented 2 years ago

Hi there, here's a PR that fixes #7 : I do not know what is the optimal way to handle this, rather, maybe in the esp32 toolchain rather than a new toolchain at all.

mirrexagon commented 2 years ago

I think this is the best way to handle it right now. I don't want to combine toolchains as that would force users to download all toolchains even if they want to use just one.

In the future, if this toolchain is used for all ESP RISC-V microcontrollers, then I will probably rename the toolchain to be more generic - but for now I don't know how that will work so I think naming it specifically for the only current ESP RISC-V chip is best (ESP32-C3 as you have done).

RaitoBezarius commented 2 years ago

I think this is the best way to handle it right now. I don't want to combine toolchains as that would force users to download all toolchains even if they want to use just one.

In the future, if this toolchain is used for all ESP RISC-V microcontrollers, then I will probably rename the toolchain to be more generic - but for now I don't know how that will work so I think naming it specifically for the only current ESP RISC-V chip is best (ESP32-C3 as you have done).

Awesome :), addressed the changes! To be fair, we have been testing this in our hackerspace, and it seems to work fine on our ESP32-C3, we have been able to run some examples and our own code.

mirrexagon commented 2 years ago

That's awesome! Thank you for adding this!