Add support for SPI Parameters

mirromutth / r2dbc-mysql

R2DBC MySQL Implementation

Apache License 2.0

656 stars 98 forks source link

Add support for SPI Parameters #215

Open mirromutth opened 3 years ago

mirromutth commented 3 years ago

It resolves #164 .

Check list:

[x] Rename dev.miku.r2dbc.mysql.Parameter into MySqlParameter to avoid user confusion and naming conflicts
[x] Add io.r2dbc.spi.Parameter support in DefaultCodecs, just like r2dbc-postgresql
[ ] Add encoding type support in Codecs, e.g. LongCodec.canEncode(Long.class, doubleValue), LongCodec.encode(Long.class, doubleValue, context)
[ ] Add integration test cases for io.r2dbc.spi.Parameter

linghengqian commented 2 years ago

What's blocking this PR from being merged?

ls-urs-keller commented 1 year ago

@mirromutth I haven't checked the PRs before doing mine. I have a slightly different implementation in https://github.com/mirromutth/r2dbc-mysql/pull/249 the name "clash" is contained to the codec, so maybe renaming your class is not necessary.